[PATCH 1/2] drm/radeon: stop re-init the TTM page pool

[Christian König]

Am 11.01.21 um 17:17 schrieb Daniel Vetter:
> On Mon, Jan 11, 2021 at 11:16:13AM +0100, Christian König wrote:
>> Am 08.01.21 um 16:53 schrieb Daniel Vetter:
>>> On Fri, Jan 8, 2021 at 3:36 PM Christian König <christian.koenig at amd.com> wrote:
>>>> Am 08.01.21 um 15:31 schrieb Daniel Vetter:
>>>>> On Thu, Jan 07, 2021 at 09:08:29PM +0100, Christian König wrote:
>>>>>> Am 07.01.21 um 19:07 schrieb Daniel Vetter:
>>>>>>> On Tue, Jan 05, 2021 at 07:23:08PM +0100, Christian König wrote:
>>>>>>>> Drivers are not supposed to init the page pool directly any more.
>>>>>>>>
>>>>>>>> Signed-off-by: Christian König <christian.koenig at amd.com>
>>>>>>> Please include reported-by credits and link to the bug reports on
>>>>>>> lore.kernel.org when merging this. Also I guess this should have a Fixes:
>>>>>>> line?
>>>>>> I'm not aware of a bug report, but the reported-by/Fixes lines are indeed
>>>>>> missing.
>>>>> This one here:
>>>>>
>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fdri-devel%2F20201231104020.GA4504%40zn.tnic%2F&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=m8tjDXFtsEwtcv9byq5r1sbUuqb8q%2BAn63r4aKMpcaM%3D&reserved=0
>>>>>
>>>>> Or did I get confused, and the above is yet another bug?
>>>> Yeah, but that was just reported by mail. The bug tracker I've saw was
>>>> opened after the patch was already pushed.
>>> Still good to give reported-by credits for mailing list reports and
>>> link to lore.kernel.org for the report, that's not just useful for
>>> bugzilla reports.
>> That's indeed true, but I was distracted by the fact that drm-misc-fixes
>> wasn't up to date :)
>>
>> Going to add that earlier next time.
>>
>>>>>> BTW: Any idea why dim add-link doesn't work?
>>>>> Hm we occasionally have fun with email parsing (it's hard) and especially
>>>>> python changes in how encodings are handled differently between python2
>>>>> and python3. If you have a specific example I can try and take a look why
>>>>> it doesn't work.
>>>> It just looks up and doesn't seem to do anything. I'm not familiar with
>>>> python so I can just describe the symptoms.
>>> I meant tell me which mail (patchwork or lore) and I'll try to
>>> reproduce and see what's maybe up.
>> It doesn't seem to work in general. E.g. any patch I try I just don't get
>> any progress in over 10 Minutes.
>>
>> Maybe some server is not responding?
> Uh dim add-link pretty similar to dim apply-patch, it takes the mbox on
> stdin and does only local git stuff with it.

AH! Since it was getting a branch parameter I was assuming that it looks 
at patches on that branch!

Thanks for the explanation,
Christian.

> -Daniel
>
>> Christian.
>>
>>> -Daniel
>>>
>>>> Christian.
>>>>
>>>>> -Daniel
>>>>>
>>>>>>> And maybe some words on how/why stuff blows up.
>>>>>> Just a typo. I've forgot to remove two lines in radeon while rebasing and
>>>>>> still had the symbols exported so never noticed this.
>>>>>>
>>>>>> Christian.
>>>>>>
>>>>>>> -Daniel
>>>>>>>
>>>>>>>> ---
>>>>>>>>      drivers/gpu/drm/radeon/radeon_ttm.c | 3 ---
>>>>>>>>      1 file changed, 3 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> index d4328ff57757..35b715f82ed8 100644
>>>>>>>> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
>>>>>>>> @@ -729,9 +729,6 @@ int radeon_ttm_init(struct radeon_device *rdev)
>>>>>>>>              }
>>>>>>>>              rdev->mman.initialized = true;
>>>>>>>> -  ttm_pool_init(&rdev->mman.bdev.pool, rdev->dev, rdev->need_swiotlb,
>>>>>>>> -                dma_addressing_limited(&rdev->pdev->dev));
>>>>>>>> -
>>>>>>>>              r = radeon_ttm_init_vram(rdev);
>>>>>>>>              if (r) {
>>>>>>>>                      DRM_ERROR("Failed initializing VRAM heap.\n");
>>>>>>>> --
>>>>>>>> 2.25.1
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> dri-devel mailing list
>>>>>>>> dri-devel at lists.freedesktop.org
>>>>>>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel&data=04%7C01%7Cchristian.koenig%40amd.com%7Cff77249040634cf2750308d8b64c616d%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637459786459556204%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=nBl4CRoSoA3t%2Bd4sZ4My4L27GiCiJwRenoILGU9LbO4%3D&reserved=0