[PATCH] drm/amd/pm: fix the return value of pm message

Du, Xiaojian Xiaojian.Du at amd.com
Tue Jan 12 10:28:39 UTC 2021


[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Xiaojian Du <xiaojian.du at amd.com>

-----Original Message-----
From: Huang, Ray <Ray.Huang at amd.com>
Sent: 2021年1月12日 18:25
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Liu, Aaron <Aaron.Liu at amd.com>; Du, Xiaojian <Xiaojian.Du at amd.com>; Hou, Xiaomeng (Matthew) <Xiaomeng.Hou at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Huang, Ray <Ray.Huang at amd.com>
Subject: [PATCH] drm/amd/pm: fix the return value of pm message

0 should be right driver return value, 0x1 is the right firmware return value. So switch to 0 at last.

Signed-off-by: Huang Rui <ray.huang at amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index d7d86fd79e1f..41d5c65a2f21 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -149,6 +149,7 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
 if (read_arg)
 smu_cmn_read_arg(smu, read_arg);

+ret = 0; /* 0 as driver return value */
 out:
 mutex_unlock(&smu->message_lock);
 return ret;
--
2.25.1



More information about the amd-gfx mailing list