[PATCH] drm/amdgpu: check the result of copy_from_user in secure display debugfs (v2)

[Deucher, Alexander]

[AMD Public Use]

> -----Original Message-----
> From: Su, Jinzhou (Joe) <Jinzhou.Su at amd.com>
> Sent: Wednesday, January 13, 2021 10:27 PM
> To: Alex Deucher <alexdeucher at gmail.com>; amd-gfx list <amd-
> gfx at lists.freedesktop.org>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: RE: [PATCH] drm/amdgpu: check the result of copy_from_user in
> secure display debugfs (v2)
> 
> [AMD Official Use Only - Internal Distribution Only]
> 
> Thanks, Alex!

Can I get a Reviewed-by or Acked-by?

Thanks!

Alex

> 
> Regards,
> Joe
> 
> -----Original Message-----
> From: Alex Deucher <alexdeucher at gmail.com>
> Sent: Thursday, January 14, 2021 11:24 AM
> To: amd-gfx list <amd-gfx at lists.freedesktop.org>; Su, Jinzhou (Joe)
> <Jinzhou.Su at amd.com>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: Re: [PATCH] drm/amdgpu: check the result of copy_from_user in
> secure display debugfs (v2)
> 
> + Joe
> 
> On Mon, Jan 4, 2021 at 12:53 PM Alex Deucher <alexdeucher at gmail.com>
> wrote:
> >
> > Make sure the copy succeeded.  Also fixes a warning.
> >
> > v2: fix the error check
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
> > index 455978781380..b033344c5ce2 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
> > @@ -101,7 +101,9 @@ static ssize_t
> amdgpu_securedisplay_debugfs_write(struct file *f, const char __u
> >                 return -EINVAL;
> >
> >         memset(str,  0, sizeof(str));
> > -       copy_from_user(str, buf, size);
> > +       ret = copy_from_user(str, buf, size);
> > +       if (ret)
> > +               return -EFAULT;
> >
> >         ret = pm_runtime_get_sync(dev->dev);
> >         if (ret < 0) {
> > --
> > 2.29.2
> >