[PATCH v4 10/14] dmr/amdgpu: Move some sysfs attrs creation to default_attr

[Greg KH]

On Tue, Jan 19, 2021 at 11:36:01AM -0500, Andrey Grodzovsky wrote:
> 
> On 1/19/21 2:34 AM, Greg KH wrote:
> > On Mon, Jan 18, 2021 at 04:01:19PM -0500, Andrey Grodzovsky wrote:
> > >   static struct pci_driver amdgpu_kms_pci_driver = {
> > >   	.name = DRIVER_NAME,
> > >   	.id_table = pciidlist,
> > > @@ -1595,6 +1607,7 @@ static struct pci_driver amdgpu_kms_pci_driver = {
> > >   	.shutdown = amdgpu_pci_shutdown,
> > >   	.driver.pm = &amdgpu_pm_ops,
> > >   	.err_handler = &amdgpu_pci_err_handler,
> > > +	.driver.dev_groups = amdgpu_sysfs_groups,
> > Shouldn't this just be:
> > 	groups - amdgpu_sysfs_groups,
> > 
> > Why go to the "driver root" here?
> 
> 
> Because I still didn't get to your suggestion to propose a patch to add groups to
> pci_driver, it's located in 'base' driver struct.

You are a pci driver, you should never have to mess with the "base"
driver struct.  Look at commit 92d50fc1602e ("PCI/IB: add support for
pci driver attribute groups") which got merged in 4.14, way back in
2017 :)

driver.pm also looks odd, but I'm just going to ignore that for now...

thanks,

greg k-h