[PATCH] drm/amd/pm: print the timeout of smc message

Quan, Evan Evan.Quan at amd.com
Thu Jan 21 02:58:28 UTC 2021


[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Evan Quan <evan.quan at amd.com>

-----Original Message-----
From: Huang, Ray <Ray.Huang at amd.com>
Sent: Wednesday, January 20, 2021 8:13 PM
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Huang, Ray <Ray.Huang at amd.com>
Subject: [PATCH] drm/amd/pm: print the timeout of smc message

This patch is to help firmware designer to know the smc message timeout
status.

Signed-off-by: Huang Rui <ray.huang at amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index e4eff6d9f092..ffd373e63f0d 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -142,10 +142,15 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,

 ret = smu_cmn_wait_for_response(smu);
 if (ret != 0x1) {
-dev_err(adev->dev, "failed send message: %10s (%d) \tparam: 0x%08x response %#x\n",
-smu_get_message_name(smu, msg), index, param, ret);
-if (ret != -ETIME)
+if (ret == -ETIME) {
+dev_err(adev->dev, "message: %10s (%d) \tparam: 0x%08x is timeout (no response)\n",
+smu_get_message_name(smu, msg), index, param);
+} else {
+dev_err(adev->dev, "failed send message: %10s (%d) \tparam: 0x%08x response %#x\n",
+smu_get_message_name(smu, msg), index, param,
+ret);
 ret = -EIO;
+}
 goto out;
 }

--
2.25.1



More information about the amd-gfx mailing list