[PATCH] ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE

Takashi Iwai tiwai at suse.de
Wed Jan 27 06:50:55 UTC 2021


On Tue, 26 Jan 2021 21:23:17 +0100,
Bjorn Helgaas wrote:
> 
> From: Bjorn Helgaas <bhelgaas at google.com>
> 
> The double negative makes it hard to read "if (!ACPI_FAILURE(status))".
> Replace it with "if (ACPI_SUCCESS(status))".
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas at google.com>
> ---
> 
> This isn't really an ACPI patch, but I'm sending it to you, Rafael, since
> it seems easier to just apply these all at once.  But I'd be happy to split
> them up into individual patches if you'd rather.
> 
> 
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 4 ++--
>  drivers/gpu/drm/radeon/radeon_bios.c     | 4 ++--
>  drivers/hwmon/acpi_power_meter.c         | 4 ++--
>  drivers/platform/x86/asus-laptop.c       | 6 +++---
>  drivers/spi/spi.c                        | 2 +-
>  sound/pci/hda/hda_intel.c                | 4 ++--

For the sound/*:
Acked-by: Takashi Iwai <tiwai at suse.de>


thanks,

Takashi


More information about the amd-gfx mailing list