[RFC PATCH 2/2] drm/amdgpu: enable gfx wave limiting for high priority compute jobs

[Nirmoy]

On 1/28/21 3:49 PM, Christian König wrote:
> Am 28.01.21 um 15:35 schrieb Nirmoy Das:
>> Enable gfx wave limiting for gfx jobs before pushing high priority
>> compute jobs so that high priority compute jobs gets more resources
>> to finish early.
>
> The problem here is what happens if you have multiple high priority 
> jobs running at the same time?


AFAIU, in that case quantum duration will come into effect. The queue 
arbiter will switch

to next high priority active queue once quantum duration expires. This 
should be similar to what

we already have, multiple normal priority jobs sharing GPU resources 
based on CP_HQD_QUANTUM.

QUEUE_DURATION register value.


Regards,

Nirmoy


>
> Christian
>
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>> index 024d0a563a65..ee48989dfb4c 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c
>> @@ -195,6 +195,10 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, 
>> unsigned num_ibs,
>>       if ((ib->flags & AMDGPU_IB_FLAG_EMIT_MEM_SYNC) && 
>> ring->funcs->emit_mem_sync)
>>           ring->funcs->emit_mem_sync(ring);
>>   +    if (ring->funcs->emit_wave_limit && job &&
>> +        job->base.s_priority >= DRM_SCHED_PRIORITY_HIGH)
>> +        ring->funcs->emit_wave_limit(ring, true);
>> +
>>       if (ring->funcs->insert_start)
>>           ring->funcs->insert_start(ring);
>>   @@ -295,6 +299,11 @@ int amdgpu_ib_schedule(struct amdgpu_ring 
>> *ring, unsigned num_ibs,
>>       ring->current_ctx = fence_ctx;
>>       if (vm && ring->funcs->emit_switch_buffer)
>>           amdgpu_ring_emit_switch_buffer(ring);
>> +
>> +    if (ring->funcs->emit_wave_limit && job &&
>> +        job->base.s_priority >= DRM_SCHED_PRIORITY_HIGH)
>> +        ring->funcs->emit_wave_limit(ring, false);
>> +
>>       amdgpu_ring_commit(ring);
>>       return 0;
>>   }
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cnirmoy.das%40amd.com%7C74280be4658d429c0cd808d8c39be149%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637474421561173374%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=TA2uh40U5C%2FhrvshW3qq85BbubKl%2FLhSpC725Xir9WQ%3D&reserved=0 
>