[PATCH] drm/amdgpu: fix the issue that retry constantly once the buffer is oversize

Christian König ckoenig.leichtzumerken at gmail.com
Sat Jan 30 15:56:12 UTC 2021


Am 30.01.21 um 10:14 schrieb Huang Rui:
> We cannot modify initial_domain every time while the retry starts. That
> will cause the busy waiting that unable to switch to GTT while the vram
> is not enough.
>
> Fixes: f8aab60422c3 ("drm/amdgpu: Initialise drm_gem_object_funcs for
> imported BOs")
>
> Signed-off-by: Huang Rui <ray.huang at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

^^ I need to run my memory pressure test more often.

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index a5c42c3004a0..b443907afcea 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -269,8 +269,8 @@ int amdgpu_gem_create_ioctl(struct drm_device *dev, void *data,
>   		resv = vm->root.base.bo->tbo.base.resv;
>   	}
>   
> -retry:
>   	initial_domain = (u32)(0xffffffff & args->in.domains);
> +retry:
>   	r = amdgpu_gem_object_create(adev, size, args->in.alignment,
>   				     initial_domain,
>   				     flags, ttm_bo_type_device, resv, &gobj);



More information about the amd-gfx mailing list