[PATCH] drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq

[Harry Wentland]

On 2021-07-19 1:49 p.m., Anson Jacob wrote:
> Fix make htmldocs complaint:
> ./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'
> 
> Signed-off-by: Anson Jacob <Anson.Jacob at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 7ed104e3756b..02bba9a202a8 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -625,7 +625,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)
>   * Handles the Outbox Interrupt
>   * event handler.
>   */
> -#define DMUB_TRACE_MAX_READ 64
>  static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>  {
>  	struct dmub_notification notify;
> @@ -635,6 +634,8 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)
>  	struct dmcub_trace_buf_entry entry = { 0 };
>  	uint32_t count = 0;
>  
> +#define DMUB_TRACE_MAX_READ 64
> +

I'd prefer to keep macro definitions separate from functions. A better
place for this would be right before the function comment.

Harry

>  	if (dc_enable_dmub_notifications(adev->dm.dc)) {
>  		if (irq_params->irq_src == DC_IRQ_SOURCE_DMCUB_OUTBOX) {
>  			do {
>