[PATCH] drm/amdgpu: Check pmops for desired suspend state

Deucher, Alexander Alexander.Deucher at amd.com
Thu Jul 22 17:12:56 UTC 2021

[AMD Official Use Only]

I sent a similar patch out a while ago, but never had a chance to follow up on it.  The problem is users might change the default.


From: Vishwakarma, Pratik <Pratik.Vishwakarma at amd.com>
Sent: Thursday, July 22, 2021 1:27 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Vishwakarma, Pratik <Pratik.Vishwakarma at amd.com>
Subject: [PATCH] drm/amdgpu: Check pmops for desired suspend state

User might set mem_sleep as deep and it will result
in amdgpu resume errors.

Check with pm for default suspend state

Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma at amd.com>
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index af1710971ff3..d92196429741 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1468,7 +1468,8 @@ static int amdgpu_pmops_suspend(struct device *dev)
         struct amdgpu_device *adev = drm_to_adev(drm_dev);
         int r;

-       if (amdgpu_acpi_is_s0ix_supported(adev))
+       if (amdgpu_acpi_is_s0ix_supported(adev)
+               && pm_suspend_default_s2idle())
                 adev->in_s0ix = true;
         adev->in_s3 = true;
         r = amdgpu_device_suspend(drm_dev, true);

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210722/357f5d50/attachment.htm>

More information about the amd-gfx mailing list