[PATCH 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

[Quan, Evan]

[AMD Official Use Only]

Thanks for reminder. As I confirmed, the OD settings will be reset to default after gpu reset.
As smu->adev->in_suspend is 0 during gpu reset. And that will reset OD settings to default.

BR
Evan
> -----Original Message-----
> From: Matt Coffin <mcoffin13 at gmail.com>
> Sent: Saturday, July 24, 2021 4:00 AM
> To: Quan, Evan <Evan.Quan at amd.com>
> Cc: amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 1/2] drm/amd/pm: restore user customized OD settings
> properly for NV1x
> 
> On 7/21/21 9:20 PM, Evan Quan wrote:
> > The customized OD settings can be divided into two parts: those
> > committed ones and non-committed ones.
> >    - For those changes which had been fed to SMU before S3/S4/Runpm
> >      suspend kicked, they are committed changes. They should be properly
> >      restored and fed to SMU on S3/S4/Runpm resume.
> >    - For those non-committed changes, they are restored only without
> feeding
> >      to SMU.
> >
> > Change-Id: Iea7cf7908dfcd919a4d0205e10bff91b1149a440
> > Signed-off-by: Evan Quan <evan.quan at amd.com>
> > ---
> 
> It's been a while since I've been through the SMU code so I don't know all
> the places that restore_uesr_profile is used, but, just to confirm, these
> would still go back to default (boot) values on a GPU reset, yes?
> 
> I ask because when pushing OD settings too far, GPU resets are often
> encountered, and you might be able to create a state where it would
> continually reset if your OD settings are remembered even through a full
> reset.
> 
> Very nice feature other than that, though, as I actually keep `radeontop`
> open in a tmux session to prevent my secondary card from resetting my OD
> settings, so this will be nice.
> 
> Thanks for listening, and for the driver in general, Matt