[PATCH 14/14] drm: IRQ midlayer is now legacy
Sam Ravnborg
sam at ravnborg.org
Wed Jul 28 14:10:53 UTC 2021
Hi Thomas,
On Tue, Jul 27, 2021 at 08:27:21PM +0200, Thomas Zimmermann wrote:
> Hide the DRM midlayer behind CONFIG_DRM_LEGACY, make functions use
> the prefix drm_legacy_, and move declarations to drm_legacy.h.
> In struct drm_device, move the fields irq and irq_enabled behind
> CONFIG_DRM_LEGACY.
>
> All callers have been updated.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
Acked-by: Sam Ravnborg <sam at ravnborg.org>
> ---
> drivers/gpu/drm/drm_irq.c | 63 ++++---------------------------
You could have pulled it all into drm_legacy_misc.c.
> drivers/gpu/drm/drm_legacy_misc.c | 3 +-
> drivers/gpu/drm/drm_vblank.c | 8 ++--
> drivers/gpu/drm/i810/i810_dma.c | 3 +-
> drivers/gpu/drm/mga/mga_dma.c | 2 +-
> drivers/gpu/drm/mga/mga_drv.h | 1 -
> drivers/gpu/drm/r128/r128_cce.c | 3 +-
> drivers/gpu/drm/via/via_mm.c | 3 +-
> include/drm/drm_device.h | 18 ++-------
> include/drm/drm_drv.h | 44 ++-------------------
> include/drm/drm_irq.h | 31 ---------------
> include/drm/drm_legacy.h | 3 ++
> 12 files changed, 27 insertions(+), 155 deletions(-)
> delete mode 100644 include/drm/drm_irq.h
Nice cleanup.
Sam
More information about the amd-gfx
mailing list