[PATCH 1/3] drm/amd/pm: Don't output SMU version for smu13 every time

[Lazar, Lijo]

On 7/30/2021 8:10 AM, Mario Limonciello wrote:
> This adjusts SMU13 to match SMU11 and SMU12 behaviors in not showing
> this message all the time.  It will still be accessible via
> /sys/kernel/debug/dri/0/amdgpu_firmware_info
> 
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> index a421ba85bd6d..9c99c51740a1 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0.c
> @@ -219,9 +219,6 @@ int smu_v13_0_check_fw_version(struct smu_context *smu)
>   		break;
>   	}
>   
> -	dev_info(smu->adev->dev, "smu fw reported version = 0x%08x (%d.%d.%d)\n",
> -			 smu_version, smu_major, smu_minor, smu_debug);
> -

Suggest to keep this at debug level. There are cases like a failed 
driver load (debugfs files are not created) where we need to check this 
information.

Thanks,
Lijo

>   	/*
>   	 * 1. if_version mismatch is not critical as our fw is designed
>   	 * to be backward compatible.
>