[PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB

Mark Yacoub markyacoub at chromium.org
Wed Jun 2 14:45:35 UTC 2021


lgtm. Thanks!

> On Wed, Jun 2, 2021 at 5:56 AM Christian König <ckoenig.leichtzumerken at gmail.com> wrote:
>>
>>
>>
>> Am 02.06.21 um 11:53 schrieb Michel Dänzer:
>> > From: Michel Dänzer <mdaenzer at redhat.com>
>> >
>> > drm_err meant broken user space could spam dmesg.
>> >
>> > Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
>> >                         size on init."
>> > Signed-off-by: Michel Dänzer <mdaenzer at redhat.com>
>>
>> Reviewed-by: Christian König <christian.koenig at amd.com>
>>
>> > ---
>> >   drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
>> >   1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > index 8170e24ce37d..2a4cd7d377bf 100644
>> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
>> > @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
>> >
>> >       return 0;
>> >   err:
>> > -     drm_err(dev, "Failed to init gem fb: %d\n", ret);
>> > +     drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
>> >       rfb->base.obj[0] = NULL;
>> >       return ret;
>> >   }
>> > @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
>> >
>> >       return 0;
>> >   err:
>> > -     drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
>> > +     drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
>> >       rfb->base.obj[0] = NULL;
>> >       return ret;
>> >   }
>>


More information about the amd-gfx mailing list