[PATCH 1/1] drm/amdkfd: remove unused variable

Kim, Jonathan Jonathan.Kim at amd.com
Tue Jun 15 10:38:03 UTC 2021


[AMD Official Use Only]

Thanks for the catch.
Reviewed-by: Jonathan Kim <jonathan.kim at amd.com>

> -----Original Message-----
> From: Das, Nirmoy <Nirmoy.Das at amd.com>
> Sent: Tuesday, June 15, 2021 6:35 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Kim, Jonathan <Jonathan.Kim at amd.com>; Kuehling, Felix
> <Felix.Kuehling at amd.com>
> Subject: Re: [PATCH 1/1] drm/amdkfd: remove unused variable
>
>
> On 6/15/2021 12:33 PM, Nirmoy Das wrote:
> > Remove it.
> >
> > CC: jonathan.kim at amd.com
> > CC: felix.kuehling at amd.com
> > Fixes: d7b132507384c("drm/amdkfd: fix circular locking on get_wave_state")
> > Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>
> > ---
> >   drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > index e6366b408420..539212039876 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> > @@ -997,7 +997,7 @@ static int start_nocpsch(struct
> device_queue_manager *dqm)
> >   {
> >     pr_info("SW scheduler is used");
> >     init_interrupts(dqm);
> > -
> > +
> Please ignore this extra space. I will push without it once I get a r-b.
> >     if (dqm->dev->device_info->asic_family == CHIP_HAWAII)
> >             return pm_init(&dqm->packets, dqm);
> >     dqm->sched_running = true;
> > @@ -1674,7 +1674,6 @@ static int get_wave_state(struct
> device_queue_manager *dqm,
> >                       u32 *save_area_used_size)
> >   {
> >     struct mqd_manager *mqd_mgr;
> > -   int r;
> >
> >     dqm_lock(dqm);
> >


More information about the amd-gfx mailing list