[PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

Christian König christian.koenig at amd.com
Fri Jun 18 08:39:26 UTC 2021


Am 18.06.21 um 10:37 schrieb Dan Carpenter:
> There is a reversed if statement in amdgpu_preempt_mgr_new() so it
> always returns -ENOMEM.
>
> Fixes: 09b020bb05a5 ("Merge tag 'drm-misc-next-2021-06-09' of git://anongit.freedesktop.org/drm/drm-misc into drm-next")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Most be some fallout from merging it with the TTM changes.

Anyway, patch is Reviewed-by: Christian König <christian.koenig at amd.com>

Thanks,
Christian.

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> index f6aff7ce5160..d02c8637f909 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_preempt_mgr.c
> @@ -71,7 +71,7 @@ static int amdgpu_preempt_mgr_new(struct ttm_resource_manager *man,
>   	struct amdgpu_preempt_mgr *mgr = to_preempt_mgr(man);
>   
>   	*res = kzalloc(sizeof(**res), GFP_KERNEL);
> -	if (*res)
> +	if (!*res)
>   		return -ENOMEM;
>   
>   	ttm_resource_init(tbo, place, *res);



More information about the amd-gfx mailing list