[PATCH V3 1/7] drm/amdgpu: correct tcp harvest setting

[Michel Dänzer]

On 2021-06-22 12:40 p.m., Lazar, Lijo wrote:
> On 6/22/2021 2:49 PM, Michel Dänzer wrote:
>> On 2021-06-22 8:08 a.m., Lazar, Lijo wrote:
>>> [Public]
>>>
>>> AFAIK, that expression is legal (some code analyzer may warn on value of 4*max_wgp_per_sh); similar kind is used in rotate shift operations.
>>
>> The default type for constants in C is int, so 0xffffffff is a 32-bit signed integer.
> 
> Probably not as per section 6.4.4.
> 
> "The type of an integer constant is the first of the corresponding list in which its value can be represented."
> 
> It is a hexadecimal constant and the first to fit this value is unsigned int.

Ah, indeed, thanks.


-- 
Earthling Michel Dänzer               |               https://redhat.com
Libre software enthusiast             |             Mesa and X developer