[PATCH 3/3] drm/amd/pm: Fix I2C controller port setting of Navi10

Alex Deucher alexdeucher at gmail.com
Mon Jun 28 17:36:49 UTC 2021


On Mon, Jun 28, 2021 at 1:26 PM Luben Tuikov <luben.tuikov at amd.com> wrote:
>
> Fix controller port setting of Navi10 from 1
> (incorrect) to 0 (correct).
>
> This fixes a previous rework commit which
> introduced this typo.
>
> Cc: Alexander Deucher <Alexander.Deucher at amd.com>
> Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>

For patches 2 and 3, please add a Fixes: line to id the commit these
fix.  With those added, the series is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> index 205dc2e56ab199..36264b78199620 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> @@ -2749,7 +2749,7 @@ static int navi10_i2c_xfer(struct i2c_adapter *i2c_adap,
>         if (!req)
>                 return -ENOMEM;
>
> -       req->I2CcontrollerPort = 1;
> +       req->I2CcontrollerPort = 0;
>         req->I2CSpeed = I2C_SPEED_FAST_400K;
>         req->SlaveAddress = msg[0].addr << 1; /* wants an 8-bit address */
>         dir = msg[0].flags & I2C_M_RD;
> --
> 2.32.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list