[PATCH] drm/amdgpu: fix S0ix handling when the CONFIG_AMD_PMC=m

Liang, Prike Prike.Liang at amd.com
Thu Mar 11 03:20:50 UTC 2021


Just find out the config variable is formed by the header_print_symbol() in the confdata.c and also can double confirm the variable config set value in the include/generated/autoconf.h. Maybe we can set the  AMD_PMC to 'y' by default in the platform Kconfig.

Thanks,
Prike
> -----Original Message-----
> From: Liang, Prike
> Sent: Wednesday, March 10, 2021 4:21 PM
> To: Alex Deucher <alexander.deucher at amd.com>; amd-
> gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: RE: [PATCH] drm/amdgpu: fix S0ix handling when the
> CONFIG_AMD_PMC=m
> 
> Not find the Kconfig script in the in-tree repo can strip the config variables
> and add  _MODULE suffix to module config variable. Not sure this  _MODULE
> variable config whether introduced by some specific ENV.
> 
> Acked-by: Prike Liang <Prike.Liang at amd.com>
> 
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > Alex Deucher
> > Sent: Wednesday, March 10, 2021 12:01 PM
> > To: amd-gfx at lists.freedesktop.org
> > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> > Subject: [PATCH] drm/amdgpu: fix S0ix handling when the
> > CONFIG_AMD_PMC=m
> >
> > Need to check the module variant as well.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > index 36a741d63ddc..2e9b16fb3fcd 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c
> > @@ -903,7 +903,7 @@ void amdgpu_acpi_fini(struct amdgpu_device
> *adev)
> >   */
> >  bool amdgpu_acpi_is_s0ix_supported(struct amdgpu_device *adev)  {
> > -#if
> > defined(CONFIG_AMD_PMC)
> > +#if defined(CONFIG_AMD_PMC) || defined(CONFIG_AMD_PMC_MODULE)
> >  	if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) {
> >  		if (adev->flags & AMD_IS_APU)
> >  			return true;
> > --
> > 2.29.2
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flist
> > s.f
> > reedesktop.org%2Fmailman%2Flistinfo%2Famd-
> >
> gfx&data=04%7C01%7CPrike.Liang%40amd.com%7Cebd55e2581834e12
> >
> ee3d08d8e37921b0%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7
> >
> C637509456690121890%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw
> >
> MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sd
> >
> ata=zKMQiqcdFs1lyuSJY2Zg3DxQemTYqCRVGtNFSiud3NA%3D&reserved
> > =0


More information about the amd-gfx mailing list