[PATCH 1/1] drm/amdgpu: fix offset calculation amdgpu_vm_bo_clear_mappings()
Christian König
christian.koenig at amd.com
Fri Mar 26 16:09:16 UTC 2021
Am 26.03.21 um 16:25 schrieb Nirmoy Das:
> Offset calculation wasn't correct as start addresses are in pfn
> not in bytes.
>
> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>
Wow that code has been around for a while without noticing this. Really
good catch.
Patch is Reviewed-by: Christian König <christian.koenig at amd.com>
CC: stable at vger.kernel.org
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index 9268db1172bd..dc4d6ae71476 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -2410,7 +2410,7 @@ int amdgpu_vm_bo_clear_mappings(struct amdgpu_device *adev,
> after->start = eaddr + 1;
> after->last = tmp->last;
> after->offset = tmp->offset;
> - after->offset += after->start - tmp->start;
> + after->offset += (after->start - tmp->start) << PAGE_SHIFT;
> after->flags = tmp->flags;
> after->bo_va = tmp->bo_va;
> list_add(&after->list, &tmp->bo_va->invalids);
More information about the amd-gfx
mailing list