[PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"

Quan, Evan Evan.Quan at amd.com
Wed Mar 31 02:20:24 UTC 2021


[AMD Public Use]

Acked-by: Evan Quan <evan.quan at amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Thursday, March 11, 2021 10:20 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Gopalakrishnan,
> Veerabadhran (Veera) <Veerabadhran.Gopalakrishnan at amd.com>; Liu, Leo
> <Leo.Liu at amd.com>
> Subject: [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
> 
> This reverts commit c6d2b0fbb893d5c7dda405aa0e7bcbecf1c75f98.
> 
> This patch is a workaround for a hardware bug, but I don't know that we've
> actually seen the hw bug triggered in practice, meanwhile a number of
> people have reported that this causes suspend and resume issues.
> 
> Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D211277&data=04%7C01%7Cev
> an.quan%40amd.com%7C106f649374b14dc3383108d8e498c485%7C3dd8961f
> e4884e608e11a82d994e183d%7C0%7C0%7C637510692088534999%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&sdata=yLxYzonL8VrQui3MrFzsgA2FIM
> mRYt3e40jtvNCtRRM%3D&reserved=0
> Cc: Veerabadhran Gopalakrishnan <veerabadhran.gopalakrishnan at amd.com>
> Cc: Leo Liu <leo.liu at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
> b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 3808402cd964..1a0c3a816863 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -1405,7 +1405,8 @@ static int soc15_common_early_init(void *handle)
> 
>  			adev->pg_flags = AMD_PG_SUPPORT_SDMA |
>  				AMD_PG_SUPPORT_MMHUB |
> -				AMD_PG_SUPPORT_VCN;
> +				AMD_PG_SUPPORT_VCN |
> +				AMD_PG_SUPPORT_VCN_DPG;
>  		} else {
>  			adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
>  				AMD_CG_SUPPORT_GFX_MGLS |
> --
> 2.29.2
> 
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=04%7C01%7Cevan.quan%40amd.com%7C106f649374b14dc33
> 83108d8e498c485%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> 7510692088534999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=
> hG2dxaaaNNQEqgpKP5opDH3reYhZYKY%2B7q1n4aEPoqA%3D&reserve
> d=0


More information about the amd-gfx mailing list