[PATCH 2/2] drm/amdgpu: drop the GCR packet from the emit_ib frame for sdma5.0

[Zhang, Hawking]

[AMD Official Use Only - Internal Distribution Only]

Series is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>

Regards,
Hawking
-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Tuesday, May 4, 2021 22:02
To: amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
Subject: [PATCH 2/2] drm/amdgpu: drop the GCR packet from the emit_ib frame for sdma5.0

It's not needed here and has been added to the proper place in the previous patch.  This aligns with what we do for sdma 5.2.

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
index d294ef6a625a..04c68a79eca4 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_0.c
@@ -405,18 +405,6 @@ static void sdma_v5_0_ring_emit_ib(struct amdgpu_ring *ring,
 unsigned vmid = AMDGPU_JOB_GET_VMID(job);
 uint64_t csa_mc_addr = amdgpu_sdma_get_csa_mc_addr(ring, vmid);

-/* Invalidate L2, because if we don't do it, we might get stale cache
- * lines from previous IBs.
- */
-amdgpu_ring_write(ring, SDMA_PKT_HEADER_OP(SDMA_OP_GCR_REQ));
-amdgpu_ring_write(ring, 0);
-amdgpu_ring_write(ring, (SDMA_GCR_GL2_INV |
- SDMA_GCR_GL2_WB |
- SDMA_GCR_GLM_INV |
- SDMA_GCR_GLM_WB) << 16);
-amdgpu_ring_write(ring, 0xffffff80);
-amdgpu_ring_write(ring, 0xffff);
-
 /* An IB packet must end on a 8 DW boundary--the next dword
  * must be on a 8-dword boundary. Our IB packet below is 6
  * dwords long, thus add x number of NOPs, such that, in
--
2.30.2

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Chawking.zhang%40amd.com%7C604d5a9a3c0348c8cc4f08d90f0547e8%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637557337630279443%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=yUKpkFGxOa8MRRXUudMEX69jweKswUwqA9FnDNsTRFE%3D&reserved=0