[PATCH] drm/amdgpu: fix the fence leak

Christian König ckoenig.leichtzumerken at gmail.com
Thu May 6 10:39:00 UTC 2021


Am 06.05.21 um 11:14 schrieb Roy Sun:
> release the unreleased fences

A bit better description what's going wrong here would be nice.

>
> Signed-off-by: Roy Sun <Roy.Sun at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> index 01fe60fedcbe..59b662947dde 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
> @@ -669,11 +669,15 @@ void amdgpu_ctx_fence_time(struct amdgpu_ctx *ctx, struct amdgpu_ctx_entity *cen
>   		if (!fence)
>   			continue;
>   		s_fence = to_drm_sched_fence(fence);
> -		if (!dma_fence_is_signaled(&s_fence->scheduled))
> +		if (!dma_fence_is_signaled(&s_fence->scheduled)) {
> +			dma_fence_put(fence);
>   			continue;
> +		}
>   		t1 = s_fence->scheduled.timestamp;
> -		if (t1 >= now)
> +		if (t1 >= now) {
> +			dma_fence_put(fence);
>   			continue;
> +		}
>   		if (dma_fence_is_signaled(&s_fence->finished) &&
>   			s_fence->finished.timestamp < now)
>   			*total += ktime_sub(s_fence->finished.timestamp, t1);



More information about the amd-gfx mailing list