[PATCH] drm/amd/display: Avoid HPD IRQ in GPU reset state

[Cornij, Nikola]

[AMD Official Use Only - Internal Distribution Only]

>
>-----Original Message-----
>From: Liu, Zhan <Zhan.Liu at amd.com>
>Sent: Sunday, May 9, 2021 10:30 PM
>To: amd-gfx at lists.freedesktop.org; Liu, Zhan <Zhan.Liu at amd.com>; Cornij, Nikola <Nikola.Cornij at amd.com>
>Subject: [PATCH] drm/amd/display: Avoid HPD IRQ in GPU reset state
>
>[Why]
>If GPU is in reset state, force enabling link will cause unexpected behaviour.
>
>[How]
>Avoid handling HPD IRQ when GPU is in reset state.
>
>Signed-off-by: Zhan Liu <zhan.liu at amd.com>
>Change-Id: I29d80501e44096068e98b5d5984e63822dfcef82
>---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>index cc048c348a92..58b59152a8be 100644
>--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>@@ -2769,15 +2769,15 @@ static void handle_hpd_rx_irq(void *param)
>               }
>       }
>
>-      if (!amdgpu_in_reset(adev))
>+      if (!amdgpu_in_reset(adev)) {
>               mutex_lock(&adev->dm.dc_lock);
> #ifdef CONFIG_DRM_AMD_DC_HDCP
>       result = dc_link_handle_hpd_rx_irq(dc_link, &hpd_irq_data, NULL);  #else
>       result = dc_link_handle_hpd_rx_irq(dc_link, NULL, NULL);  #endif
>-      if (!amdgpu_in_reset(adev))
>               mutex_unlock(&adev->dm.dc_lock);
>+      }
>
> out:
>       if (result && !is_mst_root_connector) {
>--
>2.25.1
>
>

Reviewed-by: Nikola Cornij <nikola.cornij at amd.com>