[PATCH 2/2] Revert "Revert "drm/amdgpu: Ensure that the modifier requested is supported by plane.""

[Mark Yacoub]

Like the previous time it was reverted, there is a chance it's a user
space bug that's not passing the correct modifier.
Are you able to check what exactly returns false in the code above.
This will give you the greatest hint on what the userspace is missing
and needs to be fixed there.

On Sun, May 9, 2021 at 10:09 PM youling 257 <youling257 at gmail.com> wrote:
>
> Revert "Revert "drm/amdgpu: Ensure that the modifier requested is
> supported by plane."" is first bad commt.
> "drm/amd/display: Fix two cursor duplication when using overlay" is
> second bad commit.
> they cause same problem, look the video.
> i have to revert two patch for my androidx86 run on amdgpu.
>
> 2021-05-10 5:42 GMT+08:00, youling 257 <youling257 at gmail.com>:
> > error dmesg
> >
> > [  115.977746] [drm:dm_plane_helper_prepare_fb [amdgpu]] No FB bound
> > [  115.980406] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> > [  115.993656] [drm:drm_mode_addfb2 [drm]] [FB:104]
> > [  115.993694] [drm:drm_mode_addfb2 [drm]] [FB:105]
> > [  115.993722] [drm:drm_mode_addfb2 [drm]] [FB:106]
> > [  115.993750] [drm:drm_mode_addfb2 [drm]] [FB:107]
> > [  115.993777] [drm:drm_mode_addfb2 [drm]] [FB:108]
> > [  115.994215] [drm:drm_mode_addfb2 [drm]] [FB:104]
> > [  115.994371] [drm:dm_plane_helper_prepare_fb [amdgpu]] No FB bound
> > [  115.997095] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> > [  116.010298] [drm:drm_mode_addfb2 [drm]] [FB:102]
> > [  116.010337] [drm:drm_mode_addfb2 [drm]] [FB:105]
> > [  116.010366] [drm:drm_mode_addfb2 [drm]] [FB:106]
> > [  116.010394] [drm:drm_mode_addfb2 [drm]] [FB:107]
> > [  116.010422] [drm:drm_mode_addfb2 [drm]] [FB:108]
> > [  116.010853] [drm:drm_mode_addfb2 [drm]] [FB:102]
> > [  116.011018] [drm:dm_plane_helper_prepare_fb [amdgpu]] No FB bound
> > [  116.013694] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> >
> >
> > normal dmesg
> >  3464.827004] [drm:drm_mode_addfb2 [drm]] [FB:105]
> > [ 3464.833405] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> > [ 3464.833981] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 3
> > [ 3464.842396] [drm:drm_mode_addfb2 [drm]] [FB:104]
> > [ 3464.842476] [drm:drm_mode_addfb2 [drm]] [FB:106]
> > [ 3464.842550] [drm:drm_mode_addfb2 [drm]] [FB:107]
> > [ 3464.842615] [drm:drm_mode_addfb2 [drm]] [FB:108]
> > [ 3464.842679] [drm:drm_mode_addfb2 [drm]] [FB:109]
> > [ 3464.842741] [drm:drm_mode_addfb2 [drm]] [FB:110]
> > [ 3464.843748] [drm:drm_mode_addfb2 [drm]] [FB:104]
> > [ 3464.843821] [drm:drm_mode_addfb2 [drm]] [FB:106]
> > [ 3464.850026] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> > [ 3464.850378] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 3
> > [ 3464.858841] [drm:drm_mode_addfb2 [drm]] [FB:102]
> > [ 3464.858878] [drm:drm_mode_addfb2 [drm]] [FB:105]
> > [ 3464.858906] [drm:drm_mode_addfb2 [drm]] [FB:107]
> > [ 3464.858933] [drm:drm_mode_addfb2 [drm]] [FB:108]
> > [ 3464.858960] [drm:drm_mode_addfb2 [drm]] [FB:109]
> > [ 3464.858987] [drm:drm_mode_addfb2 [drm]] [FB:110]
> > [ 3464.859609] [drm:drm_mode_addfb2 [drm]] [FB:102]
> > [ 3464.859641] [drm:drm_mode_addfb2 [drm]] [FB:105]
> > [ 3464.866353] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 0
> > [ 3464.866653] [drm:dcn10_program_pipe [amdgpu]] Un-gated front end for pipe
> > 3
> >
> > 2021-05-10 4:57 GMT+08:00, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>:
> >> It would be very helpful if you could enable drm.debug=0x4 and then
> >> take the dmesg to figure out what modifier was rejected
> >>
> >> On Sun, May 9, 2021 at 10:51 PM youling 257 <youling257 at gmail.com> wrote:
> >>>
> >>> look this video,
> >>> https://drive.google.com/file/d/1QklH_H2AlOTu8W1D3yl6_3rtZ7IqbjR_/view?usp=sharing
> >>>
> >>> 2021-05-09 23:52 GMT+08:00, Alex Deucher <alexdeucher at gmail.com>:
> >>> > On Sun, May 9, 2021 at 11:42 AM youling257 <youling257 at gmail.com>
> >>> > wrote:
> >>> >>
> >>> >> I using amd 3400g running with android-x86, this patch is a bad
> >>> >> commit
> >>> >> when i use android-x86 on amdgpu.
> >>> >
> >>> > Can you provide more details?  What sort of problem are you seeing?
> >>> > Please provide your dmesg output.
> >>> >
> >>> > Alex
> >>> >
> >>> >
> >>> >> _______________________________________________
> >>> >> amd-gfx mailing list
> >>> >> amd-gfx at lists.freedesktop.org
> >>> >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
> >>> >
> >>
> >