[PATCH] drm/amdgpu: avoid undefined return value

[Alex Deucher]

On Mon, May 10, 2021 at 5:56 AM Leslie Shi <Yuliang.Shi at amd.com> wrote:
>
> Fixes: a7c22df2fd07 ("drm/amdgpu: clean up non-DC suspend/resume handling")
>
> Signed-off-by: Leslie Shi <Yuliang.Shi at amd.com>

I think this was already fixed in:
commit e64a779ad509391dcdb3d0d4014d81e6db2ac001
Author: Victor Zhao <Victor.Zhao at amd.com>
Date:   Tue Apr 27 17:52:56 2021 +0800

    drm/amdgpu: fix r initial values

    Sriov gets suspend of IP block <dce_virtual> failed as return
    value was not initialized.

    v2: return 0 directly to align original code semantic before this
    was broken out into a separate helper function instead of setting
    initial values

    Signed-off-by: Victor Zhao <Victor.Zhao at amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher at amd.com>


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 7d4af8fc7e97..f3b2762f6f53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1554,7 +1554,7 @@ int amdgpu_display_suspend_helper(struct amdgpu_device *adev)
>         struct drm_crtc *crtc;
>         struct drm_connector *connector;
>         struct drm_connector_list_iter iter;
> -       int r;
> +       int r = 0;
>
>         /* turn off display hw */
>         drm_modeset_lock_all(dev);
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx