[PATCH] drm/amd/display: Initialize attribute for hdcp_srm sysfs file

[Alex Deucher]

Applied.  Thanks!

Alex

On Mon, May 10, 2021 at 5:31 AM David Ward <david.ward at gatech.edu> wrote:
>
> It is stored in dynamically allocated memory, so sysfs_bin_attr_init() must
> be called to initialize it. (Note: "initialization" only sets the .attr.key
> member in this struct; it does not change the value of any other members.)
>
> Otherwise, when CONFIG_DEBUG_LOCK_ALLOC=y this message appears during boot:
>
>     BUG: key ffff9248900cd148 has not been registered!
>
> Fixes: a193ed2094ba ("drm/amd/display: Add sysfs interface for set/get srm")
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1586
> Reported-by: Mikhail Gavrilov <mikhail.v.gavrilov at gmail.com>
> Signed-off-by: David Ward <david.ward at gatech.edu>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
> index 60f91853bd82..6965126d771d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c
> @@ -644,6 +644,7 @@ struct hdcp_workqueue *hdcp_create_workqueue(struct amdgpu_device *adev, struct
>
>         /* File created at /sys/class/drm/card0/device/hdcp_srm*/
>         hdcp_work[0].attr = data_attr;
> +       sysfs_bin_attr_init(&hdcp_work[0].attr);
>
>         if (sysfs_create_bin_file(&adev->dev->kobj, &hdcp_work[0].attr))
>                 DRM_WARN("Failed to create device file hdcp_srm");
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx