[PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

[Gu, JiaWei (Will)]

[AMD Official Use Only - Internal Distribution Only]

Done. UMR patch sent out.

Hi Tom,

Please help review it to bring the umr part back.

Thanks in advance!
Jiawei

From: Deucher, Alexander <Alexander.Deucher at amd.com>
Sent: Tuesday, May 11, 2021 9:16 PM
To: Gu, JiaWei (Will) <JiaWei.Gu at amd.com>; amd-gfx at lists.freedesktop.org
Cc: StDenis, Tom <Tom.StDenis at amd.com>; keescook at chromium.org; Nieto, David M <David.Nieto at amd.com>
Subject: Re: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios


[AMD Official Use Only - Internal Distribution Only]

Please update the umr patch as well.

Acked-by: Alex Deucher <alexander.deucher at amd.com<mailto:alexander.deucher at amd.com>>

________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org<mailto:amd-gfx-bounces at lists.freedesktop.org>> on behalf of Jiawei Gu <Jiawei.Gu at amd.com<mailto:Jiawei.Gu at amd.com>>
Sent: Tuesday, May 11, 2021 1:31 AM
To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>
Cc: StDenis, Tom <Tom.StDenis at amd.com<mailto:Tom.StDenis at amd.com>>; Gu, JiaWei (Will) <JiaWei.Gu at amd.com<mailto:JiaWei.Gu at amd.com>>; keescook at chromium.org<mailto:keescook at chromium.org> <keescook at chromium.org<mailto:keescook at chromium.org>>; Nieto, David M <David.Nieto at amd.com<mailto:David.Nieto at amd.com>>
Subject: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

Use numeric type serial in drm_amdgpu_info_vbios instead.

Signed-off-by: Jiawei Gu <Jiawei.Gu at amd.com<mailto:Jiawei.Gu at amd.com>>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +-
 include/uapi/drm/amdgpu_drm.h           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
index 75f34a9008e7..e1008a79b441 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c
@@ -871,7 +871,7 @@ int amdgpu_info_ioctl(struct drm_device *dev, void *data, struct drm_file *filp)
                         memcpy(vbios_info.vbios_pn, atom_context->vbios_pn, sizeof(atom_context->vbios_pn));
                         vbios_info.version = atom_context->version;
                         memcpy(vbios_info.date, atom_context->date, sizeof(atom_context->date));
-                       memcpy(vbios_info.serial, adev->serial, sizeof(adev->serial));
+                       vbios_info.serial = adev->unique_id;
                         vbios_info.dev_id = adev->pdev->device;
                         vbios_info.rev_id = adev->pdev->revision;
                         vbios_info.sub_dev_id = atom_context->sub_dev_id;
diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h
index 2b487a8d2727..2d9e84658bbc 100644
--- a/include/uapi/drm/amdgpu_drm.h
+++ b/include/uapi/drm/amdgpu_drm.h
@@ -957,7 +957,7 @@ struct drm_amdgpu_info_vbios {
         __u8 vbios_pn[64];
         __u32 version;
         __u8 date[32];
-       __u8 serial[16];
+       __u64 serial;
         __u32 dev_id;
         __u32 rev_id;
         __u32 sub_dev_id;
--
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Calexander.deucher%40amd.com%7C9c3ad129089d4585544f08d9143e1892%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637563079204768525%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=efCxiLv4J5KWmoKqy1geARlt%2FJppT1eetVI3R%2FMNfzw%3D&reserved=0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210512/d100f92f/attachment-0001.htm>