[PATCH] drm/amd/amdgpu: fix refcount leak

[Alex Deucher]

On Mon, May 17, 2021 at 4:47 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> Am 17.05.21 um 10:26 schrieb Jingwen Chen:
> > [Why]
> > the gem object rfb->base.obj[0] is get according to num_planes
> > in amdgpufb_create, but is not put according to num_planes
> >
> > [How]
> > put rfb->base.obj[0] in amdgpu_fbdev_destroy according to num_planes
> >
> > Signed-off-by: Jingwen Chen <Jingwen.Chen2 at amd.com>
>
> Looks sane to me, but Alex might want to take a look as well.
>
> Acked-by: Christian König <christian.koenig at amd.com>

Looks good to me as well.

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > index 4f10c4529840..09b048647523 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c
> > @@ -288,10 +288,13 @@ static int amdgpufb_create(struct drm_fb_helper *helper,
> >   static int amdgpu_fbdev_destroy(struct drm_device *dev, struct amdgpu_fbdev *rfbdev)
> >   {
> >       struct amdgpu_framebuffer *rfb = &rfbdev->rfb;
> > +     int i;
> >
> >       drm_fb_helper_unregister_fbi(&rfbdev->helper);
> >
> >       if (rfb->base.obj[0]) {
> > +             for (i = 0; i < rfb->base.format->num_planes; i++)
> > +                     drm_gem_object_put(rfb->base.obj[0]);
> >               amdgpufb_destroy_pinned_object(rfb->base.obj[0]);
> >               rfb->base.obj[0] = NULL;
> >               drm_framebuffer_unregister_private(&rfb->base);
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx