[PATCH v2 5/6] drm/amdgpu: remove unused code

[Christian König]

Am 27.05.21 um 13:53 schrieb Nirmoy Das:
> Remove unused code related to shadow BO.
>
> v2: removing shadow bo ptr from base class.
>
> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>

Reviewed-by: Christian König <christian.koenig at amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 29 ----------------------
>   drivers/gpu/drm/amd/amdgpu/amdgpu_object.h |  6 -----
>   2 files changed, 35 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> index a63b450cd603..db9c64836556 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> @@ -638,35 +638,6 @@ int amdgpu_bo_create(struct amdgpu_device *adev,
>   	return r;
>   }
>
> -int amdgpu_bo_create_shadow(struct amdgpu_device *adev,
> -			    unsigned long size,
> -			    struct amdgpu_bo *bo)
> -{
> -	struct amdgpu_bo_param bp;
> -	int r;
> -
> -	if (bo->shadow)
> -		return 0;
> -
> -	memset(&bp, 0, sizeof(bp));
> -	bp.size = size;
> -	bp.domain = AMDGPU_GEM_DOMAIN_GTT;
> -	bp.flags = AMDGPU_GEM_CREATE_CPU_GTT_USWC;
> -	bp.type = ttm_bo_type_kernel;
> -	bp.resv = bo->tbo.base.resv;
> -	bp.bo_ptr_size = sizeof(struct amdgpu_bo);
> -
> -	r = amdgpu_bo_create(adev, &bp, &bo->shadow);
> -	if (!r) {
> -		bo->shadow->parent = amdgpu_bo_ref(bo);
> -		mutex_lock(&adev->shadow_list_lock);
> -		list_add_tail(&bo->shadow->shadow_list, &adev->shadow_list);
> -		mutex_unlock(&adev->shadow_list_lock);
> -	}
> -
> -	return r;
> -}
> -
>   /**
>    * amdgpu_bo_create_user - create an &amdgpu_bo_user buffer object
>    * @adev: amdgpu device object
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> index 9afccf6c66f2..fa75251148be 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.h
> @@ -104,9 +104,6 @@ struct amdgpu_bo {
>   	struct amdgpu_vm_bo_base	*vm_bo;
>   	/* Constant after initialization */
>   	struct amdgpu_bo		*parent;
> -	struct amdgpu_bo		*shadow;
> -
> -
>
>   #ifdef CONFIG_MMU_NOTIFIER
>   	struct mmu_interval_notifier	notifier;
> @@ -300,9 +297,6 @@ int amdgpu_bo_create_vm(struct amdgpu_device *adev,
>   			struct amdgpu_bo_vm **ubo_ptr);
>   void amdgpu_bo_free_kernel(struct amdgpu_bo **bo, u64 *gpu_addr,
>   			   void **cpu_addr);
> -int amdgpu_bo_create_shadow(struct amdgpu_device *adev,
> -			    unsigned long size,
> -			    struct amdgpu_bo *bo);
>   int amdgpu_bo_kmap(struct amdgpu_bo *bo, void **ptr);
>   void *amdgpu_bo_kptr(struct amdgpu_bo *bo);
>   void amdgpu_bo_kunmap(struct amdgpu_bo *bo);
> --
> 2.31.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx