[PATCH 1/2] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY

[Yu, Lang]

[Public]

>Hi,

>On 5/27/21 3:30 AM, Lang Yu wrote:
>> Make TTM_PL_FLAG_* start from zero and add
>> TTM_PL_FLAG_TEMPORARY flag for temporary
>> GTT allocation use.

>GTT is a driver private acronym, right? And it doesn't look like 
>TTM_PL_FLAG_TEMPORARY will be used in core TTM, so should we instead set 
>aside a mask in the PL flag for driver-private use?

Hi Thomas,  

Thanks for your comments and advice, GTT means Graphics Translation Table here, seems
a general acronym. TTM_PL_FLAG_TEMPORARY may also be used by other drives.
I have made other patches for this. Please help review. 

Regards,
Lang

>Thomas

>-----Original Message-----
>From: Yu, Lang <Lang.Yu at amd.com>
>Sent: Thursday, May 27, 2021 9:31 AM
>To: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org
>Cc: Koenig, Christian <Christian.Koenig at amd.com>; Huang, Ray
><Ray.Huang at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>;
>Yu, Lang <Lang.Yu at amd.com>
>Subject: [PATCH 1/2] drm/ttm: cleanup and add TTM_PL_FLAG_TEMPORARY
>
>Make TTM_PL_FLAG_* start from zero and add TTM_PL_FLAG_TEMPORARY flag
>for temporary GTT allocation use.
>
>Signed-off-by: Lang Yu <Lang.Yu at amd.com>
>---
> include/drm/ttm/ttm_placement.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/include/drm/ttm/ttm_placement.h
>b/include/drm/ttm/ttm_placement.h index aa6ba4d0cf78..9f5cfc7c2d5a 100644
>--- a/include/drm/ttm/ttm_placement.h
>+++ b/include/drm/ttm/ttm_placement.h
>@@ -47,8 +47,9 @@
>  * top of the memory area, instead of the bottom.
>  */
>
>-#define TTM_PL_FLAG_CONTIGUOUS  (1 << 19)
>-#define TTM_PL_FLAG_TOPDOWN     (1 << 22)
>+#define TTM_PL_FLAG_CONTIGUOUS  (1 << 0)
>+#define TTM_PL_FLAG_TOPDOWN     (1 << 1)
>+#define TTM_PL_FLAG_TEMPORARY   (1 << 2)
>
> /**
>  * struct ttm_place
>--
>2.25.1