[PATCH v2 2/2] drm/ttm: check with temporary GTT memory in BO validation

Christian König christian.koenig at amd.com
Mon May 31 11:54:31 UTC 2021


Am 31.05.21 um 13:30 schrieb Lang Yu:
> If a BO's backing store is temporary GTT memory, we should
> move it in BO validation.
>
> v2: move the check outside of for loop
>
> Signed-off-by: Lang Yu <Lang.Yu at amd.com>

In general those patches now have my rb, but let me add some more 
documentation to them to better explain why we do this.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/ttm/ttm_bo.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index c32a37d0a460..1802fc77cfcb 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -938,6 +938,9 @@ static bool ttm_bo_places_compat(const struct ttm_place *places,
>   {
>   	unsigned i;
>   
> +	if (mem->placement & TTM_PL_FLAG_TEMPORARY)
> +		return false;
> +
>   	for (i = 0; i < num_placement; i++) {
>   		const struct ttm_place *heap = &places[i];
>   



More information about the amd-gfx mailing list