bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12 UVD/VCE on suspend")

[Quan, Evan]

[AMD Official Use Only]

Hi Boris,

We are finalizing the solution for the issue here.
I'm wondering are you able to give the attached patch(alone) a try.
Since that might give us a different approach(more reasonable) to get the issue fixed.

BR
Evan

> -----Original Message-----
> From: Quan, Evan
> Sent: Friday, October 15, 2021 5:25 PM
> To: Borislav Petkov <bp at alien8.de>
> Cc: Alex Deucher <alexdeucher at gmail.com>; amd-gfx list <amd-
> gfx at lists.freedesktop.org>; LKML <linux-kernel at vger.kernel.org>; Deucher,
> Alexander <Alexander.Deucher at amd.com>; Pan, Xinhui
> <Xinhui.Pan at amd.com>; Chen, Guchun <Guchun.Chen at amd.com>
> Subject: RE: bf756fb833cb ("drm/amdgpu: add missing cleanups for Polaris12
> UVD/VCE on suspend")
> 
> [AMD Official Use Only]
> 
> 
> 
> > -----Original Message-----
> > From: Borislav Petkov <bp at alien8.de>
> > Sent: Thursday, October 14, 2021 5:01 PM
> > To: Quan, Evan <Evan.Quan at amd.com>
> > Cc: Alex Deucher <alexdeucher at gmail.com>; amd-gfx list <amd-
> > gfx at lists.freedesktop.org>; LKML <linux-kernel at vger.kernel.org>;
> > Deucher, Alexander <Alexander.Deucher at amd.com>; Pan, Xinhui
> > <Xinhui.Pan at amd.com>; Chen, Guchun <Guchun.Chen at amd.com>
> > Subject: Re: bf756fb833cb ("drm/amdgpu: add missing cleanups for
> > Polaris12 UVD/VCE on suspend")
> >
> > On Thu, Oct 14, 2021 at 02:02:48AM +0000, Quan, Evan wrote:
> > > [Quan, Evan] Yes, but not(apply them) at the same time. One by one
> > > as
> > you did before.
> > > - try the patch1 first
> >
> > Ok, first patch worked fine.
> >
> > > - undo the changes of patch1 and try patch2
> >
> > Did that, worked fine too except after the first resume cycle, the
> > video didn't continue playing.
> >
> > Then I restarted the video and did a couple more suspend cycles to see
> > if it would not continue again. In the subsequent tries it would
> > resume fine and the video would continue playing too.
> >
> > So I'm going to chalk that single case of halted video with the second
> > patch to a resume glitch or so.
> >
> > Btw, I don't have pm-suspend on that box but I did suspend to RAM
> > assuming this is what you wanted, which is done as root with two
> > commands:
> >
> > # echo "suspend" > /sys/power/disk
> > # echo "mem" > /sys/power/state
> [Quan, Evan] Yes, that also works.
> >
> > If you want me to do more extensive testing, just shoot.
> [Quan, Evan] Thanks! That's enough for now. I will prepare an official solution
> for the issue.
> 
> BR
> Evan
> >
> > HTH.
> >
> > --
> > Regards/Gruss,
> >     Boris.
> >
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeo
> > ple.kernel.org%2Ftglx%2Fnotes-about-
> >
> netiquette&data=04%7C01%7CEvan.Quan%40amd.com%7C08df3d5453
> >
> d64ad40dfa08d98ef119ec%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C
> >
> 0%7C637697988457790715%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
> >
> AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&
> >
> sdata=zmFVlmUBv6byoDYyUhSgk9J9Zmvexz5IqG7xBxwiR3M%3D&rese
> > rved=0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-amd-pm-avoid-duplicate-powergate-ungate-setting.patch
Type: application/octet-stream
Size: 5932 bytes
Desc: 0001-drm-amd-pm-avoid-duplicate-powergate-ungate-setting.patch
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211105/6ded6de6/attachment-0001.obj>