[PATCH 2/2] drm/amd/pm: Print the error on command submission

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deucher at amd.com>

On Wed, Nov 17, 2021 at 1:56 PM Luben Tuikov <luben.tuikov at amd.com> wrote:
>
> Print the error on command submission immediately after submitting to
> the SMU. This is rate-limited. It helps to immediately know there was an
> error on command submission, rather than leave it up to clients to report
> the error, as sometimes they do not.
>
> Cc: Alex Deucher <Alexander.Deucher at amd.com>
> Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index f9a42a07eeaebf..048ca16738638f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -352,7 +352,7 @@ int smu_cmn_send_smc_msg_with_param(struct smu_context *smu,
>         __smu_cmn_send_msg(smu, (uint16_t) index, param);
>         reg = __smu_cmn_poll_stat(smu);
>         res = __smu_cmn_reg2errno(smu, reg);
> -       if (res == -EREMOTEIO)
> +       if (res != 0)
>                 __smu_cmn_reg_print_error(smu, reg, index, param, msg);
>         if (read_arg)
>                 smu_cmn_read_arg(smu, read_arg);
> --
> 2.34.0
>