回复: [PATCH Review 1/4] drm/amdgpu: Update smu driver interface for aldebaran

[Yang, Stanley]

[AMD Official Use Only]

Thanks Evan,

Will update patch 1 and 3 title before submit.

Regards,
Stanley
> -----邮件原件-----
> 发件人: Quan, Evan <Evan.Quan at amd.com>
> 发送时间: Thursday, November 18, 2021 5:58 PM
> 收件人: Yang, Stanley <Stanley.Yang at amd.com>; amd-
> gfx at lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang at amd.com>;
> Clements, John <John.Clements at amd.com>; Lazar, Lijo
> <Lijo.Lazar at amd.com>; Wang, Yang(Kevin) <KevinYang.Wang at amd.com>
> 抄送: Yang, Stanley <Stanley.Yang at amd.com>
> 主题: RE: [PATCH Review 1/4] drm/amdgpu: Update smu driver interface for
> aldebaran
> 
> [AMD Official Use Only]
> 
> Better to update the patch title as "drm/amd/pm: Update smu driver
> interface for aldebaran" as all other power related patches.
> And please update patch3 also.
> Other than above, patch 1, 3 are reviewed-by: Evan Quan
> <evan.quan at amd.com>
> > -----Original Message-----
> > From: Stanley.Yang <Stanley.Yang at amd.com>
> > Sent: Thursday, November 18, 2021 5:34 PM
> > To: amd-gfx at lists.freedesktop.org; Zhang, Hawking
> > <Hawking.Zhang at amd.com>; Clements, John
> <John.Clements at amd.com>; Quan,
> > Evan <Evan.Quan at amd.com>; Lazar, Lijo <Lijo.Lazar at amd.com>; Wang,
> > Yang(Kevin) <KevinYang.Wang at amd.com>
> > Cc: Yang, Stanley <Stanley.Yang at amd.com>
> > Subject: [PATCH Review 1/4] drm/amdgpu: Update smu driver interface
> > for aldebaran
> >
> > update smu driver if version to 0x08 to avoid mismatch log A version
> > mismatch can still happen with an older FW
> >
> > Change-Id: I97f2bc4ed9a9cba313b744e2ff6812c90b244935
> > Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com>
> > ---
> >  .../drm/amd/pm/inc/smu13_driver_if_aldebaran.h | 18
> > +++++++++++++++++-
> >  drivers/gpu/drm/amd/pm/inc/smu_v13_0.h         |  2 +-
> >  2 files changed, 18 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/inc/smu13_driver_if_aldebaran.h
> > b/drivers/gpu/drm/amd/pm/inc/smu13_driver_if_aldebaran.h
> > index a017983ff1fa..0f67c56c2863 100644
> > --- a/drivers/gpu/drm/amd/pm/inc/smu13_driver_if_aldebaran.h
> > +++ b/drivers/gpu/drm/amd/pm/inc/smu13_driver_if_aldebaran.h
> > @@ -140,6 +140,8 @@
> >
> >  #define MAX_SW_I2C_COMMANDS                24
> >
> > +#define ALDEBARAN_UMC_CHANNEL_NUM    32
> > +
> >  typedef enum {
> >    I2C_CONTROLLER_PORT_0, //CKSVII2C0
> >    I2C_CONTROLLER_PORT_1, //CKSVII2C1
> > @@ -507,6 +509,19 @@ typedef struct {
> >    uint32_t MmHubPadding[8]; // SMU internal use  } AvfsDebugTable_t;
> >
> > +typedef struct {
> > +	uint64_t mca_umc_status;
> > +	uint64_t mca_umc_addr;
> > +	uint16_t ce_count_lo_chip;
> > +	uint16_t ce_count_hi_chip;
> > +
> > +	uint32_t eccPadding;
> > +} EccInfo_t;
> > +
> > +typedef struct {
> > +	EccInfo_t  EccInfo[ALDEBARAN_UMC_CHANNEL_NUM];
> > +} EccInfoTable_t;
> > +
> >  // These defines are used with the following messages:
> >  // SMC_MSG_TransferTableDram2Smu
> >  // SMC_MSG_TransferTableSmu2Dram
> > @@ -517,6 +532,7 @@ typedef struct {
> >  #define TABLE_SMU_METRICS             4
> >  #define TABLE_DRIVER_SMU_CONFIG       5
> >  #define TABLE_I2C_COMMANDS            6
> > -#define TABLE_COUNT                   7
> > +#define TABLE_ECCINFO                 7
> > +#define TABLE_COUNT                   8
> >
> >  #endif
> > diff --git a/drivers/gpu/drm/amd/pm/inc/smu_v13_0.h
> > b/drivers/gpu/drm/amd/pm/inc/smu_v13_0.h
> > index bbc608c990b0..44af23ae059e 100644
> > --- a/drivers/gpu/drm/amd/pm/inc/smu_v13_0.h
> > +++ b/drivers/gpu/drm/amd/pm/inc/smu_v13_0.h
> > @@ -27,7 +27,7 @@
> >
> >  #define SMU13_DRIVER_IF_VERSION_INV 0xFFFFFFFF  #define
> > SMU13_DRIVER_IF_VERSION_YELLOW_CARP 0x04 -#define
> > SMU13_DRIVER_IF_VERSION_ALDE 0x07
> > +#define SMU13_DRIVER_IF_VERSION_ALDE 0x08
> >
> >  #define SMU13_MODE1_RESET_WAIT_TIME_IN_MS 500  //500ms
> >
> > --
> > 2.17.1