[PATCH] drm/amd/display: Fix Werror when building

Alex Deucher alexdeucher at gmail.com
Fri Oct 8 13:51:03 UTC 2021


Acked-by: Alex Deucher <alexander.deucher at amd.com>

On Fri, Oct 8, 2021 at 9:39 AM Wayne Lin <Wayne.Lin at amd.com> wrote:
>
> [Why & How]
> Got Werror when building with Clang-13:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:195:2:
> error: variable 'ts' is used uninitialized whenever switch default is
> taken [-Werror,-Wsometimes-uninitialized]
>
>         default:
>
>         ^~~~~~~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:200:9:
> note: uninitialized use occurs here
>
>         return ts;
>
>                ^~
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dpia.c:180:2:
> note: variable 'ts' is declared here
>
>         enum dpia_set_config_ts ts;
>
>         ^
>
> 1 error generated.
>
> Fix it.
>
> Reported-by: Mike Lothian <mike at fireburn.co.uk>
> Signed-off-by: Wayne Lin <Wayne.Lin at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> index 6936b9d549e5..64d2461953c4 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dpia.c
> @@ -193,6 +193,7 @@ static enum dpia_set_config_ts convert_trng_ptn_to_trng_stg(enum dc_dp_training_
>                 ts = DPIA_TS_TPS4;
>                 break;
>         default:
> +               ts = DPIA_TS_DPRX_DONE;
>                 ASSERT(false); /* TPS not supported by helper function. */
>                 break;
>         }
> --
> 2.25.1
>


More information about the amd-gfx mailing list