[PATCH] drm/amdgpu: Restore information reporting in RAS

[Russell, Kent]

[AMD Official Use Only]



> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling at amd.com>
> Sent: Monday, October 25, 2021 1:30 PM
> To: Tuikov, Luben <Luben.Tuikov at amd.com>; amd-gfx at lists.freedesktop.org
> Cc: Russell, Kent <Kent.Russell at amd.com>; Deucher, Alexander
> <Alexander.Deucher at amd.com>
> Subject: Re: [PATCH] drm/amdgpu: Restore information reporting in RAS
> 
> Am 2021-10-25 um 12:02 p.m. schrieb Luben Tuikov:
> > A recent patch took away the reporting of number of RAS records and
> > the threshold due to the way it was edited/spliced on top of the code.
> > This patch restores this reporting.
> >
> > Cc: Kent Russell <kent.russell at amd.com>
> > Cc: Alex Deucher <Alexander.Deucher at amd.com>
> > Fixes: 07df2fb092d09e ("drm/amdgpu: Add kernel parameter support for ignoring bad
> page threshold")
> > Signed-off-by: Luben Tuikov <luben.tuikov at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> > index ae64ca02ccc4f8..05117eda105b55 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
> > @@ -1112,7 +1112,10 @@ int amdgpu_ras_eeprom_init(struct
> amdgpu_ras_eeprom_control *control,
> >  				res = 0;
> >  			} else {
> >  				*exceed_err_limit = true;
> > -				dev_err(adev->dev, "GPU will not be initialized. Replace this
> GPU or increase the threshold.");
> > +				dev_err(adev->dev,
> > +					"RAS records:%d exceed threshold:%d, "
> > +					"GPU will not be initialized. Replace this GPU or
> increase the threshold",
> 
> Splitting messages across multiple lines is usually discouraged
> (presumably because it makes them hard to grep). I think checkpatch will
> treat this as an error, while a long line is just a warning. Therefore
> it seems that long lines are less bad than split messages.

There are a few spots in the eeprom file where it gets done like this; I don't really like it either. Under https://www.kernel.org/doc/html/v5.13/process/coding-style.html , I see it supporting splitting for ASM (point 20) but not for regular string (point 2). 

In this one he's just restoring something I dropped, verbatim, so I have no issue giving it my RB.

 Kent

> 
> Regards,
>   Felix
> 
> 
> > +					control->ras_num_recs, ras-
> >bad_page_cnt_threshold);
> >  			}
> >  		}
> >  	} else {
> >
> > base-commit: b60bccb408c831c685b2a257eff575bcda2cbe9d