[PATCH] drm/amd/pm: Update intermediate power state for SI

[Alex Deucher]

Acked-by: Alex Deucher <alexander.deucher at amd.com>
Fixes: f9b7f3703ff9 ("drm/amdgpu/acpi: make ATPX/ATCS structures global (v2)")

Thanks!

On Thu, Sep 23, 2021 at 12:30 AM Lijo Lazar <lijo.lazar at amd.com> wrote:
>
> Update the current state as boot state during dpm initialization.
> During the subsequent initialization, set_power_state gets called to
> transition to the final power state. set_power_state refers to values
> from the current state and without current state populated, it could
> result in NULL pointer dereference.
>
> Bug:https://gitlab.freedesktop.org/drm/amd/-/issues/1698
>
> Signed-off-by: Lijo Lazar <lijo.lazar at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/si_dpm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c b/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c
> index bdbbeb959c68..81f82aa05ec2 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/si_dpm.c
> @@ -6867,6 +6867,8 @@ static int si_dpm_enable(struct amdgpu_device *adev)
>         si_enable_auto_throttle_source(adev, AMDGPU_DPM_AUTO_THROTTLE_SRC_THERMAL, true);
>         si_thermal_start_thermal_controller(adev);
>
> +       ni_update_current_ps(adev, boot_ps);
> +
>         return 0;
>  }
>
> --
> 2.17.1
>