[PATCH] drm/amdgpu: don't use BACO for reset in S3

[Paul Menzel]

Dear Alex,


Thank you for your patch.

Am 31.03.22 um 16:56 schrieb Alex Deucher:
> Seems to cause a reboots or hangs on some systems.

It’d be great if you listed the systems from the bug reports.

> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1924
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1953
> Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> index c73fb73e9628..1ff6c42fb110 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> @@ -173,6 +173,9 @@ bool amdgpu_dpm_is_baco_supported(struct amdgpu_device *adev)
>   
>   	if (!pp_funcs || !pp_funcs->get_asic_baco_capability)
>   		return false;
> +	/* don't use baco for reset in S3 */

In issue #1924, I think you also write, it’s a workaround. Maybe make 
that clear in the comment?

> +	if (adev->in_s3)
> +		return false;
>   
>   	mutex_lock(&adev->pm.mutex);
>   


Kind regards,

Paul