[PATCH V4 17/17] drm/amd/pm: unified lock protections in amdgpu_dpm.c

[Quan, Evan]

[AMD Official Use Only]

Hi Arthur,

Can you try to blacklist amdgpu module first and then do manual driver loading? 
Hope via that you can have a chance to observe the errors reported by driver.

BR
Evan
> -----Original Message-----
> From: Arthur Marsh <arthur.marsh at internode.on.net>
> Sent: Thursday, March 31, 2022 12:27 PM
> To: Quan, Evan <Evan.Quan at amd.com>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; Feng, Kenneth <Kenneth.Feng at amd.com>;
> Lazar, Lijo <Lijo.Lazar at amd.com>; amd-gfx at lists.freedesktop.org;
> arthur.marsh at internode.on.net
> Subject: [PATCH V4 17/17] drm/amd/pm: unified lock protections in
> amdgpu_dpm.c
> 
> Hi Evan, even with the patch below applied and built, I was still getting no
> signal to the monitor upon loading of the amdgpu module and no response
> from the pc except when giving the magic sysreq boot key sequence.
> 
> .config has:
> 
> CONFIG_DRM_AMDGPU=m
> CONFIG_DRM_AMDGPU_SI=y
> # CONFIG_DRM_AMDGPU_CIK is not set
> # CONFIG_DRM_AMDGPU_USERPTR is not set
> 
> kernel command line has:
> 
> amdgpu.audio=1 amdgpu.si_support=1 radeon.si_support=0
> page_owner=on amdgpu.gpu_recovery=1
> 
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> index 89fbee568be4..d7dc9c5b3df9 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> @@ -80,8 +80,6 @@ int amdgpu_dpm_set_powergating_by_smu(struct
> amdgpu_device *adev, uint32_t block
>  		return 0;
>  	}
> 
> -	mutex_lock(&adev->pm.mutex);
> -
>  	switch (block_type) {
>  	case AMD_IP_BLOCK_TYPE_UVD:
>  	case AMD_IP_BLOCK_TYPE_VCE:
> @@ -102,8 +100,6 @@ int amdgpu_dpm_set_powergating_by_smu(struct
> amdgpu_device *adev, uint32_t block
>  	if (!ret)
>  		atomic_set(&adev->pm.pwr_state[block_type], pwr_state);
> 
> -	mutex_unlock(&adev->pm.mutex);
> -
>  	return ret;
>  }
> 
> 
> Regards,
> 
> Arthur Marsh.