[PATCH v2] drm/amdgpu: don't use BACO for reset in S3

[Lazar, Lijo]

On 4/1/2022 7:32 PM, Alex Deucher wrote:
> Seems to cause a reboots or hangs on some systems.
> 
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1924
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1953
> Fixes: daf8de0874ab5b ("drm/amdgpu: always reset the asic in suspend (v2)")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>   drivers/gpu/drm/amd/pm/amdgpu_dpm.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> index c73fb73e9628..ee62c74685ae 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_dpm.c
> @@ -173,6 +173,13 @@ bool amdgpu_dpm_is_baco_supported(struct amdgpu_device *adev)
>   
>   	if (!pp_funcs || !pp_funcs->get_asic_baco_capability)
>   		return false;
> +	/* Don't use baco for reset in S3.
> +	 * This is a workaround for some platforms
> +	 * where entering BACO during suspend
> +	 * seems to cause reboots or hangs.
> +	 */
> +	if (adev->in_s3)
> +		return false;
>   
You may also mention about the thing that there is no device link checks 
during suspend, so it is not a safe thing to forcefully power off 
through BACO.

Reviewed-by: Lijo Lazar <lijo.lazar at amd.com>

Thanks,
Lijo

>   	mutex_lock(&adev->pm.mutex);
>   
>