[PATCH] drm/amdgpu: Fix NULL pointer dereference

Grigory Vasilyev h0tc0d3 at gmail.com
Fri Apr 8 13:21:04 UTC 2022


Simon Ser and Bas Nieuwenhuizen, do you understand that you are
proposing to make the code less safe in the future? In the future,
someone might rewrite the code and we'll get an error.

пт, 8 апр. 2022 г. в 14:48, Simon Ser <contact at emersion.fr>:
>
> On Friday, April 8th, 2022 at 13:28, Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl> wrote:
>
> > On Fri, Apr 8, 2022 at 12:01 PM Simon Ser contact at emersion.fr wrote:
> >
> > > Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surface?
> > > If not, there's no point in adding NULL checks.
> >
> > It isn't called with NULL anywhere, the NULL checks that already exist
> > seem redundant.
>
> Grigory, would be be willing to submit a v2 which removes the unnecessary
> NULL checks?


More information about the amd-gfx mailing list