[PATCH 03/20] drm/amd/display: Disabling Z10 on DCN31

[Paul Menzel]

Dear Pavle, dear syerizvi,


Thank you for the patch.

Am 08.04.22 um 19:18 schrieb Pavle Kotarac:
> From: "AMD\\syerizvi" <syerizvi at amd.com>

Please correct the author name.

Imperative mood should be used in the commit message summary: Disable Z10 ….

> 
> [WHY]
> Z10 is should not be enabled by default on DCN31.

According to what source?

> 
> [HOW]
> Using DC debug flags to disable Z10 by default on DCN31.

s/Using/Use/

Why is that grouped under debug flags? Does not seem related.

> 
> Reviewed-by: Eric Yang <Eric.Yang2 at amd.com>
> Acked-by: Pavle Kotarac <Pavle.Kotarac at amd.com>
> Signed-off-by: AMD\syerizvi <syerizvi at amd.com>

Please fix the name.

> ---
>   drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> index f27262417abe..6cc580be7c79 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> @@ -885,6 +885,7 @@ static const struct dc_debug_options debug_defaults_drv = {
>   			.afmt = true,
>   		}
>   	},
> +	.disable_z10 = true,
>   	.optimize_edp_link_rate = true,
>   	.enable_sw_cntl_psr = true,
>   	.apply_vendor_specific_lttpr_wa = true,


Kind regards,

Paul