[PATCH 1/2] drm/amd/amdgpu: Update PF2VF header

Paul Menzel pmenzel at molgen.mpg.de
Wed Apr 13 07:05:06 UTC 2022


[Removed unintended paste in second line]

Am 13.04.22 um 09:03 schrieb Paul Menzel:
> Dear Bokun,
> 
> 
> Thank you for rerolling the patch. Please add the iteration/version in 
> the subject next time `[PATCH v2 1/2]` or so.
> 
> Am 12.04.22 um 23:31 schrieb Bokun Zhang:
>> - Add proper indentation in the header file
> 
> Please use that as the commit message summary, and the subject/summary 
> as the title for the cover letter? Maybe:
> 
> drm/amd/amdgpu: Properly indent PF2VF header
> 
>> Signed-off-by: Bokun Zhang <Bokun.Zhang at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h | 95 ++++++++++-----------
>>   1 file changed, 46 insertions(+), 49 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h 
>> b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
>> index 7326b6c1b71c..65433cbb00c5 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h
>> @@ -1,34 +1,33 @@
>>   /*
>> - * Copyright 2018-2019 Advanced Micro Devices, Inc.
>> + * Copyright (c) 2018-2021 Advanced Micro Devices, Inc. All rights reserved.
>>    *
>> - * Permission is hereby granted, free of charge, to any person obtaining a
>> - * copy of this software and associated documentation files (the "Software"),
>> - * to deal in the Software without restriction, including without limitation
>> - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
>> - * and/or sell copies of the Software, and to permit persons to whom the
>> - * Software is furnished to do so, subject to the following conditions:
>> + * Permission is hereby granted, free of charge, to any person obtaining a copy
>> + * of this software and associated documentation files (the "Software"), to deal
>> + * in the Software without restriction, including without limitation the rights
>> + * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
>> + * copies of the Software, and to permit persons to whom the Software is
>> + * furnished to do so, subject to the following conditions:
>>    *
>>    * The above copyright notice and this permission notice shall be included in
>>    * all copies or substantial portions of the Software.
>>    *
>>    * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
>>    * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
>> - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
>> - * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
>> - * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
>> - * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
>> - * OTHER DEALINGS IN THE SOFTWARE.
>> - *
>> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL THE
>> + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
>> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
>> + * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
>> + * THE SOFTWARE.
>>    */
> 
> The header change seems unrelated from indentation?
> 
> […]
> 
> 
> Kind regards,
> 
> Paul


More information about the amd-gfx mailing list