[PATCH] drm/amd/display: set panel orientation before drm_dev_register

Simon Ser contact at emersion.fr
Fri Aug 5 17:34:09 UTC 2022


Hi,

Have you seen [1] and [2]? CC'ing Sean and Hans, it seems like there's
a disagreement regarding probing early vs. setting the initial value to
UNKNOWN.

If a driver doesn't fetch EDIDs before exposing them to user-space,
then there is an amount of time where the connectors are exposed as
CONNECTED but their EDID and mode list isn't properly set. But maybe
that's what the GETCONNECTOR IOCTLs is supposed to do: probe the
connector, fetch its EDID, return the proper mode list. So maybe
drivers shouldn't probe early and should let user-space request probes?
In which case we could create the panel orientation prop with "Normal",
and update it accordingly when probing.

At any rate, I've tested v2 on the Deck and it works properly.

Tested-by: Simon Ser <contact at emersion.fr>

Thanks,

Simon

[1]: https://lore.kernel.org/dri-devel/CAMavQKJUpYP8jo2JDGMYNBGtbPSSO7z9BAComm5JQoty=HPtJg@mail.gmail.com/
[2]: https://lore.kernel.org/dri-devel/20220530081910.3947168-1-hsinyi@chromium.org/


More information about the amd-gfx mailing list