[PATCH 0/4] Fix S3 and S4 issues related to fbdev

Mario Limonciello mario.limonciello at amd.com
Tue Aug 9 15:10:04 UTC 2022


Moving to the generic fbdev helper introduced a regression in S4 support
on Hawaii PRO graphics cards.  A workaround commit was introduced to
avoid this S4 regression until the root cause could be found, but that
workaround commit introduced a completely separate regression on S3 on
a WX3200.

This series reverts all the code to move to generic fbdev helpers to
fix both issues.

Mario Limonciello (4):
  Revert "drm/amdgpu/display: disable prefer_shadow for generic fb
    helpers"
  Revert "drm/amdgpu: keep fbdev buffers pinned during suspend"
  Revert "drm/amdgpu: drop amdgpu_display_gem_fb_init()"
  Revert "drm/amdgpu: use generic fb helpers instead of setting up AMD
    own's."

 drivers/gpu/drm/amd/amdgpu/Makefile           |   2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c    |  12 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c   |  43 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  13 -
 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c        | 388 ++++++++++++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c       |  30 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |  25 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c      |   3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v10_0.c        |   3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v11_0.c        |   3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v6_0.c         |   3 +-
 drivers/gpu/drm/amd/amdgpu/dce_v8_0.c         |   3 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |   3 +-
 13 files changed, 457 insertions(+), 74 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c

-- 
2.34.1



More information about the amd-gfx mailing list