[PATCH linux-next] drm/amdgpu/vcn: Remove unused assignment in vcn_v4_0_stop

James Zhu jamesz at amd.com
Mon Aug 15 14:07:05 UTC 2022


ThispatchisReviewed-by:JamesZhu<James.Zhu at amd.com>

On 2022-08-15 3:00 a.m., Khalid Masum wrote:
> The value assigned from vcn_v4_0_stop_dbg_mode to r is overwritten
> before it can be used. Remove this assignment.
>
> Addresses-Coverity: 1504988 ("Unused value")
> Fixes: 8da1170a16e4 ("drm/amdgpu: add VCN4 ip block support")
> Signed-off-by: Khalid Masum<khalid.masum.92 at gmail.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index ca14c3ef742e..80b8a2c66b36 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1154,7 +1154,7 @@ static int vcn_v4_0_stop(struct amdgpu_device *adev)
>   		fw_shared->sq.queue_mode |= FW_QUEUE_DPG_HOLD_OFF;
>   
>   		if (adev->pg_flags & AMD_PG_SUPPORT_VCN_DPG) {
> -			r = vcn_v4_0_stop_dpg_mode(adev, i);
> +			vcn_v4_0_stop_dpg_mode(adev, i);
>   			continue;
>   		}
>   
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20220815/36747899/attachment.htm>


More information about the amd-gfx mailing list