[PATCH] drm/amd: remove possible condition with no effect (if == else)

[Alex Deucher]

Applied.  Thanks!

Alex

On Tue, Aug 23, 2022 at 3:01 AM Bernard Zhao <bernard at vivo.com> wrote:
>
> This patch fix cocci warning:
> drivers/gpu/drm/amd/display/dc/core/dc.c:3335:2-4: WARNING:
> possible condition with no effect (if == else).
>
> Signed-off-by: Bernard Zhao <bernard at vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index aeecca68dea7..2d4c44083d79 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3332,13 +3332,8 @@ static void commit_planes_for_stream(struct dc *dc,
>                 /* Since phantom pipe programming is moved to post_unlock_program_front_end,
>                  * move the SubVP lock to after the phantom pipes have been setup
>                  */
> -               if (should_lock_all_pipes && dc->hwss.interdependent_update_lock) {
> -                       if (dc->hwss.subvp_pipe_control_lock)
> -                               dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes, NULL, subvp_prev_use);
> -               } else {
> -                       if (dc->hwss.subvp_pipe_control_lock)
> -                               dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes, NULL, subvp_prev_use);
> -               }
> +               if (dc->hwss.subvp_pipe_control_lock)
> +                       dc->hwss.subvp_pipe_control_lock(dc, context, false, should_lock_all_pipes, NULL, subvp_prev_use);
>                 return;
>         }
>
> --
> 2.33.1
>