[PATCH] drm/radeon: remove modeset parameter

Christian König ckoenig.leichtzumerken at gmail.com
Tue Aug 30 08:16:25 UTC 2022


People sometimes still think they can enable UMS by specifying
radeon.modeset=0 on the kernel command line, but UMS support was
removed years ago and the driver just fails to load when the option is
specified.

If the driver shouldn't load at all then this can be easily done with
modprobe.blacklist=radeon on the kernel command line.

Signed-off-by: Christian König <christian.koenig at amd.com>
---
 drivers/gpu/drm/radeon/radeon.h     | 1 -
 drivers/gpu/drm/radeon/radeon_drv.c | 9 +--------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h
index 08f83bf2c330..c7f31a9ab403 100644
--- a/drivers/gpu/drm/radeon/radeon.h
+++ b/drivers/gpu/drm/radeon/radeon.h
@@ -88,7 +88,6 @@
  * Modules parameters.
  */
 extern int radeon_no_wb;
-extern int radeon_modeset;
 extern int radeon_dynclks;
 extern int radeon_r4xx_atom;
 extern int radeon_agpmode;
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c
index 956c72b5aa33..fca6702213a5 100644
--- a/drivers/gpu/drm/radeon/radeon_drv.c
+++ b/drivers/gpu/drm/radeon/radeon_drv.c
@@ -144,7 +144,6 @@ static inline bool radeon_is_atpx_hybrid(void) { return false; }
 #endif
 
 int radeon_no_wb;
-int radeon_modeset = -1;
 int radeon_dynclks = -1;
 int radeon_r4xx_atom = 0;
 int radeon_agpmode = -1;
@@ -179,9 +178,6 @@ int radeon_vce = 1;
 MODULE_PARM_DESC(no_wb, "Disable AGP writeback for scratch registers");
 module_param_named(no_wb, radeon_no_wb, int, 0444);
 
-MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
-module_param_named(modeset, radeon_modeset, int, 0400);
-
 MODULE_PARM_DESC(dynclks, "Disable/Enable dynamic clocks");
 module_param_named(dynclks, radeon_dynclks, int, 0444);
 
@@ -636,10 +632,7 @@ static struct pci_driver radeon_kms_pci_driver = {
 
 static int __init radeon_module_init(void)
 {
-	if (drm_firmware_drivers_only() && radeon_modeset == -1)
-		radeon_modeset = 0;
-
-	if (radeon_modeset == 0)
+	if (drm_firmware_drivers_only())
 		return -EINVAL;
 
 	DRM_INFO("radeon kernel modesetting enabled.\n");
-- 
2.25.1



More information about the amd-gfx mailing list