[PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7

Patel, Krunalkumar Mukeshkumar KrunalkumarMukeshkumar.Patel at amd.com
Mon Dec 5 07:06:58 UTC 2022


[AMD Official Use Only - General]

[ABANDON] The changes are not required at the moment. As the patch is not merged I would like to mark this as abandoned.

Thanks

From: Gao, Likun <Likun.Gao at amd.com>
Sent: Tuesday, November 8, 2022 10:14 AM
To: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Pan, Xinhui <Xinhui.Pan at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
Cc: amd-gfx at lists.freedesktop.org; S, Shirish <Shirish.S at amd.com>
Subject: RE: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7


[AMD Official Use Only - General]

Looks good to me, this patch is Reviewed-by: Likun Gao <Likun.Gao at amd.com<mailto:Likun.Gao at amd.com>>

Regards,
Likun

From: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel at amd.com<mailto:KrunalkumarMukeshkumar.Patel at amd.com>>
Sent: Tuesday, November 8, 2022 11:46 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com<mailto:Alexander.Deucher at amd.com>>; Pan, Xinhui <Xinhui.Pan at amd.com<mailto:Xinhui.Pan at amd.com>>; Koenig, Christian <Christian.Koenig at amd.com<mailto:Christian.Koenig at amd.com>>; Gao, Likun <Likun.Gao at amd.com<mailto:Likun.Gao at amd.com>>; Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>
Cc: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; S, Shirish <Shirish.S at amd.com<mailto:Shirish.S at amd.com>>
Subject: Re: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7


[AMD Official Use Only - General]

+Likun, Hawking

Hi,

Can you please help with the review of the patch?

Thanks and regards
Krunal
________________________________
From: Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel at amd.com<mailto:KrunalkumarMukeshkumar.Patel at amd.com>>
Sent: Monday, November 7, 2022 1:35:01 PM
To: Deucher, Alexander <Alexander.Deucher at amd.com<mailto:Alexander.Deucher at amd.com>>; Pan, Xinhui <Xinhui.Pan at amd.com<mailto:Xinhui.Pan at amd.com>>; Koenig, Christian <Christian.Koenig at amd.com<mailto:Christian.Koenig at amd.com>>
Cc: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>; S, Shirish <Shirish.S at amd.com<mailto:Shirish.S at amd.com>>; Patel, Krunalkumar Mukeshkumar <KrunalkumarMukeshkumar.Patel at amd.com<mailto:KrunalkumarMukeshkumar.Patel at amd.com>>
Subject: [PATCH] drm/amdgpu: Add support to clock gating for sdma 5.2.7

With this change it will add support for clock gating for sdma 5.2.7

- Additional changes are to re-arrange the chip version sequentially.

Signed-off-by: Krunal Patel <krunalkumarmukeshkumar.patel at amd.com<mailto:krunalkumarmukeshkumar.patel at amd.com>>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
index 809eca54fc61..404b255cb4e0 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
@@ -1647,12 +1647,13 @@ static int sdma_v5_2_set_clockgating_state(void *handle,

         switch (adev->ip_versions[SDMA0_HWIP][0]) {
         case IP_VERSION(5, 2, 0):
-       case IP_VERSION(5, 2, 2):
         case IP_VERSION(5, 2, 1):
+       case IP_VERSION(5, 2, 2):
+       case IP_VERSION(5, 2, 3):
         case IP_VERSION(5, 2, 4):
         case IP_VERSION(5, 2, 5):
         case IP_VERSION(5, 2, 6):
-       case IP_VERSION(5, 2, 3):
+       case IP_VERSION(5, 2, 7):
                 sdma_v5_2_update_medium_grain_clock_gating(adev,
                                 state == AMD_CG_STATE_GATE);
                 sdma_v5_2_update_medium_grain_light_sleep(adev,
--
2.25.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: winmail.dat
Type: application/ms-tnef
Size: 26463 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20221205/4dbbc754/attachment-0001.bin>


More information about the amd-gfx mailing list